Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): monitor the pressure sensor more #15246

Merged
merged 4 commits into from
May 28, 2024

Conversation

ryanthecoder
Copy link
Contributor

@ryanthecoder ryanthecoder commented May 22, 2024

Overview

This will allow us to monitor the pressure sensor more, specifically it should help us catch and differentiate cases where the tip collides with the labware by monitoring it during the z movement in addition to the plunger movement.
Should help diagnose:
RABR-319
RABR-305
RABR-304

Test Plan

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested a review from a team as a code owner May 22, 2024 14:20
Copy link
Contributor

@caila-marashaj caila-marashaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. I like this.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but let's add tests at least for moving_pipettes_in_move_group please

@ryanthecoder ryanthecoder requested review from a team as code owners May 28, 2024 15:14
@ryanthecoder ryanthecoder requested review from smb2268 and removed request for a team May 28, 2024 15:14
@ryanthecoder ryanthecoder force-pushed the increase-overpressure-monitering branch from ef08704 to 400adb3 Compare May 28, 2024 15:15
@ryanthecoder ryanthecoder removed request for smb2268 and a team May 28, 2024 15:19
@ryanthecoder ryanthecoder merged commit 28069f8 into edge May 28, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants